On Wed, Mar 13, 2024 at 1:29 PM Ilya Maximets <[email protected]> wrote: > > RTE_MBUF_F_TX_TCP_CKSUM is not a flag, but a 2-bit field, so checking > it with a simple binary 'and' is incorrect. For example, this check > will succeed for a packet with UDP checksum requested as well. > > Fix the check to avoid wrongly initializing tso_segz and potentially > accessing UDP header via TCP structure pointer. > > The IPv4 checksum flag has to be set for any L4 checksum request, > regardless of the type, so moving this check out of the TCP condition. > > Fixes: 8b5fe2dc6080 ("userspace: Add Generic Segmentation Offloading.") > Signed-off-by: Ilya Maximets <[email protected]>
Acked-by: Mike Pattrick <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
