On 3/14/24 15:17, Mike Pattrick wrote: > On Wed, Mar 13, 2024 at 1:29 PM Ilya Maximets <[email protected]> wrote: >> >> Tunnel types are not flags, but 4-bit fields, so checking them with >> a simple binary 'and' is incorrect and may produce false-positive >> matches. >> >> While the current implementation is unlikely to cause any issues today, >> since both RTE_MBUF_F_TX_TUNNEL_VXLAN and RTE_MBUF_F_TX_TUNNEL_GENEVE >> only have 1 bit set, it is risky to have this code and it may lead >> to problems if we add support for other tunnel types in the future. >> >> Use proper field checks instead. Also adding a warning for unexpected >> tunnel types in case something goes wrong. >> >> Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.") >> Signed-off-by: Ilya Maximets <[email protected]> > > Acked-by: Mike Pattrick <[email protected]> >
Thanks, Mike! I applied the set and backported to 3.3. best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
