On Fri, May 31, 2024 at 11:45:11PM +0200, Ilya Maximets wrote: > These tests contain plain hex dumps that are hard to read and modify. > Replace with equivalent calls to ovs-ofctl compose-packet --bare and > ovs-pcap. > > Tcpdump calls modified to write actual pcaps instead of text output, > so ovs-pcap can be used while checking the results. > > While at it, replacing sleeps with more robust waiting for tcpdump > to start listening.
I might have put that part in a separate patch, but I don't feel strongly about it. > > M4 macros are better than shell variables, because we can see the > substitution result in the test log. So, using m4_define and m4_join > extensively. > > Signed-off-by: Ilya Maximets <[email protected]> Acked-by: Simon Horman <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
