On Fri, May 31, 2024 at 11:45:12PM +0200, Ilya Maximets wrote: > OVS can parse NSH, but can't compose. Fix that and get rid of plain > hex NSH packets in system tests as they are hard to read or modify. > > Tcpdump calls modified to write actual pcaps instead of text output, > so ovs-pcap can be used while checking the results. > > While at it, replacing sleeps with more robust waiting for tcpdump > to start listening.
I might have separated a) adding NSH compose support b) more robust tcpdump waiting, and c) using text rather than hex, into 3 patches. But I don't feel strongly about it. > M4 macros are better than shell variables, because we can see the > substitution result in the test log. So, using m4_define and m4_join > extensively. > > Signed-off-by: Ilya Maximets <[email protected]> Acked-by: Simon Horman <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
