It is observed in some environments that there are much more ukeys than actual DP flows. For example:
$ ovs-appctl upcall/show system@ovs-system: flows : (current 7) (avg 6) (max 117) (limit 2125) offloaded flows : 525 dump duration : 1063ms ufid enabled : true 23: (keys 3612) 24: (keys 3625) 25: (keys 3485) The revalidator threads are busy revalidating the stale ukeys leading to high CPU and long dump duration. This patch adds checks in the sweep phase for such ukeys and move them to DELETE so that they can be cleared eventually. Co-authored-by: Han Zhou <[email protected]> Signed-off-by: Han Zhou <[email protected]> Signed-off-by: Roi Dayan <[email protected]> --- ofproto/ofproto-dpif-upcall.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index 83609ec62b63..08b3c70411aa 100644 --- a/ofproto/ofproto-dpif-upcall.c +++ b/ofproto/ofproto-dpif-upcall.c @@ -278,6 +278,7 @@ enum flow_del_reason { FDR_BAD_ODP_FIT, /* Bad ODP flow fit. */ FDR_FLOW_IDLE, /* Flow idle timeout. */ FDR_FLOW_LIMIT, /* Kill all flows condition reached. */ + FDR_FLOW_NO_STATS_IDLE, /* Flow idled out without receiving statistics. */ FDR_FLOW_WILDCARDED, /* Flow needs a narrower wildcard mask. */ FDR_NO_OFPROTO, /* Bridge not found. */ FDR_PURGE, /* User requested flow deletion. */ @@ -2450,7 +2451,14 @@ revalidate_ukey(struct udpif *udpif, struct udpif_key *ukey, log_unexpected_stats_jump(ukey, stats); } - if (need_revalidate) { + if (!ukey->stats.used + && ukey->created < udpif->dpif->current_ms - ofproto_max_idle) { + /* If the flow has a 'used' value of 0, meaning no stats were received + * for this flow, and the configured idle time has elapsed, it might + * indicates a stale flow (i.e., a flow without an installed datapath + * rule). In this case, it is safe to mark this ukey for deletion. */ + *del_reason = FDR_FLOW_NO_STATS_IDLE; + } else if (need_revalidate) { if (should_revalidate(udpif, ukey, push.n_packets)) { if (!ukey->xcache) { ukey->xcache = xlate_cache_new(); -- 2.21.0 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
