On Thu, Jul 11, 2024 at 10:18 PM Vipul Ashri via dev <[email protected]> wrote: > > > While running a test with a continous VM creation/deletion using an > orchestration script with-in cloud environment. In parallel we have > some monitoring script calling ovs-appctl dpctl/show stats commands > every minute. > > During VHU port delete, one of netdev references were not reduced to > 0 as show_dpif call has not given-up the reference back or doing bad > cleanup. This pending deference preventing VHU deletion sequence, this > is found to be one of corner case inside dpctl code which results in > leaking up netdev which ultimately results in stale VHU entry. After > fixing this problematic cleanup, issue is not seen. > > Fixes: fceef2095222 ("dpctl: add ovs-appctl dpctl/* commands to talk to > dpif-netdev") > Signed-off-by: Vipul Ashri <[email protected]>
The issue seems generic as any netdev for which a call to netdev_get_stats failed would trigger the same leak. So I would update the commit title with something more generic like: dpctl: Fix netdev reference leak in "show" command. This can probably be changed when applying. In any case, the fix lgtm. Reviewed-by: David Marchand <[email protected]> -- David Marchand _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
