On Wed, Jul 17, 2024 at 01:31:41PM +0100, Simon Horman wrote:
> On Tue, Jul 16, 2024 at 01:57:36PM +0530, Vipul Ashri wrote:
> > This specific Netdev leak is causing us stale VHU entries, where it
> > is showing false limit reaching maximum and preventing us to create
> > new entries for us. This leak can impact other nics also.
> >
> > Steps to reproduce,
> > While running a test with a continous VM creation/deletion using an
> > orchestration script with-in cloud environment. In parallel we have
> > some monitoring script calling ovs-appctl dpctl/show stats commands
> > every minute.
> >
> > Root-cause analysis,
> > During VHU port delete, one of netdev references were not reduced to
> > 0 as show_dpif call has not given-up the reference back or doing bad
> > cleanup. This pending deference preventing VHU deletion sequence, this
> > is found to be one of corner case inside dpctl code which results in
> > leaking up netdev which ultimately results in stale VHU entry. After
> > fixing this problematic cleanup, issue is not seen.
> >
> > Fixes: fceef2095222 ("dpctl: add ovs-appctl dpctl/* commands to talk to
> > dpif-netdev")
> > Signed-off-by: Vipul Ashri <[email protected]>
>
> Thanks,
>
> Applied with David's tag from v1:
>
> - dpctl: Fix netdev reference leak in "show" command.
> https://github.com/openvswitch/ovs/commit/3985fa03b5c9
>
> I will follow-up by working on backports.
I have now also applied the following backports.
Backport to branch-3.4
- dpctl: Fix netdev reference leak in "show" command.
https://github.com/openvswitch/ovs/commit/12f9e14104e8
Backport to branch-3.3
- dpctl: Fix netdev reference leak in "show" command.
https://github.com/openvswitch/ovs/commit/9c439c23e688
Backport to branch-3.2
- dpctl: Fix netdev reference leak in "show" command.
https://github.com/openvswitch/ovs/commit/8c1eca08fa55
Backport to branch-3.1
- dpctl: Fix netdev reference leak in "show" command.
https://github.com/openvswitch/ovs/commit/be777868541c
Backport to branch-3.0
- dpctl: Fix netdev reference leak in "show" command.
https://github.com/openvswitch/ovs/commit/e538108f8c64
Backport to branch-2.17
- dpctl: Fix netdev reference leak in "show" command.
https://github.com/openvswitch/ovs/commit/d7fa3c3ff60b
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
