On Fri, Jul 12, 2024 at 10:30:23AM +0200, David Marchand wrote:
> Caught by code review, calling netdev_open works in pair of netdev_close
> when no reference to a netdev must be kept.
>
> Fixes: 921c370a9df5 ("dpif-netlink: Probe for out-of-tree tunnels, decides
> used interface")
> Signed-off-by: David Marchand <[email protected]>
> ---
> lib/dpif-netlink-rtnl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/dpif-netlink-rtnl.c b/lib/dpif-netlink-rtnl.c
> index 5788294ae0..f7035333e6 100644
> --- a/lib/dpif-netlink-rtnl.c
> +++ b/lib/dpif-netlink-rtnl.c
> @@ -566,6 +566,7 @@ dpif_netlink_rtnl_probe_oot_tunnels(void)
>
> tnl_cfg = netdev_get_tunnel_config(netdev);
> if (!tnl_cfg) {
> + netdev_close(netdev);
> return true;
> }
>
IIRC, the out-of-tree modules have been removed since 3.0. I think this
probe could be removed entirely.
At any rate, giving my ACK for this patch.
Acked-by: Eric Garver <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
