On 7/17/24 15:50, Simon Horman wrote: > On Fri, Jul 12, 2024 at 05:14:47PM +0200, David Marchand wrote: >> On Fri, Jul 12, 2024 at 5:03 PM Eric Garver <[email protected]> wrote: >>> >>> IIRC, the out-of-tree modules have been removed since 3.0. I think this >>> probe could be removed entirely. >> >> I was wondering too if this code should be dropped, but at least from >> a backport pov, this fix seems to make sense. >> >>> At any rate, giving my ACK for this patch. >>> >>> Acked-by: Eric Garver <[email protected]> >> >> Thanks. > > Thanks David and Eric, > > Applied to main. > > - dpif-netlink-rtnl: Fix netdev leak in out-of-tree tunnels probe. > https://github.com/openvswitch/ovs/commit/03cd668e05c2 > > As a follow-up I'll work on backporting. > > Please do consider following-up on removing the check entirely.
I think, we should keep the code as long as there is still one supported version (2.17) that technically ships the modules. We'll need to do a larger cleanup after 3.5 release when 2.17 will go EoL. Also, I wonder which interface windows tunnels are using... Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
