On 29 Aug 2024, at 10:43, Simon Horman wrote:
> On Wed, Aug 28, 2024 at 10:32:01AM -0400, Aaron Conole wrote: >> Eelco Chaudron <[email protected]> writes: >> >>> On 27 Aug 2024, at 18:01, Mike Pattrick wrote: >>> >>>> Coverity identified the following issue >>>> >>>> CID 425094: (#1 of 1): Unchecked return value (CHECKED_RETURN) >>>> 4. check_return: Calling dp_packet_hwol_tx_ip_csum without checking >>>> return value (as is done elsewhere 9 out of 11 times). >>>> >>>> This appears to be a true positive, the fields getter was called instead >>>> of its setter. >>>> >>>> Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.") >>>> Reported-by: Eelco Chaudron <[email protected]> >>>> Signed-off-by: Mike Pattrick <[email protected]> >>> >>> Thanks for the patch! The fix looks good to me. Is there any reason >>> why none of the CI tests picked this up? I guess we need real hardware >>> to verify this. >> >> I guess we have identified a coverage gap. :) > > I'm inclined to think that can be addressed as a follow-up. > >>> Cheers, >>> >>> Eelco >>> >>> Acked-by: Eelco Chaudron <[email protected]> > > Acked-by: Simon Horman <[email protected]> > > Eelco, will you will handle applying this (or not)? Thanks Simon, yes I’ll apply it. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
