On 27 Aug 2024, at 18:01, Mike Pattrick wrote:
> Coverity identified the following issue
>
> CID 425094: (#1 of 1): Unchecked return value (CHECKED_RETURN)
> 4. check_return: Calling dp_packet_hwol_tx_ip_csum without checking
> return value (as is done elsewhere 9 out of 11 times).
>
> This appears to be a true positive, the fields getter was called instead
> of its setter.
>
> Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
> Reported-by: Eelco Chaudron <[email protected]>
> Signed-off-by: Mike Pattrick <[email protected]>
Thanks to Mike and the reviewers. This patch has been applied and backported
till 3.3.
Cheers,
Eelco
> ---
> lib/netdev-native-tnl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-tnl.c
> index 16c56608d..529d64fe1 100644
> --- a/lib/netdev-native-tnl.c
> +++ b/lib/netdev-native-tnl.c
> @@ -254,7 +254,7 @@ dp_packet_tnl_ol_process(struct dp_packet *packet,
>
> if (IP_VER(ip->ip_ihl_ver) == 4) {
> dp_packet_hwol_set_tx_ipv4(packet);
> - dp_packet_hwol_tx_ip_csum(packet);
> + dp_packet_hwol_set_tx_ip_csum(packet);
> } else if (IP_VER(ip->ip_ihl_ver) == 6) {
> dp_packet_hwol_set_tx_ipv6(packet);
> }
> --
> 2.43.5
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
