On 21 Oct 2024, at 21:23, Ilya Maximets wrote:

> Specifying data_files makes setuptools install this file to a global
> sys.prefix.  So, it ends up in both the main directory of the python
> package and in the /usr/ovs-flowviz.conf, which is not good:
>
>  warning: install_data: setup script did not provide a directory for
>           'ovs/flowviz/ovs-flowviz.conf' -- installing right in
>           'build/bdist.linux-x86_64/wheel/ovs-3.4.90.data/data'
>  adding 'ovs-3.4.90.data/data/ovs-flowviz.conf'
>
> There is no real point installing this file globally, just use the
> package_data to ensure it is included in the python package.
>
> Signed-off-by: Ilya Maximets <[email protected]>

Thanks for taking a look at the installer part. The changes look good to me.

Acked-by: Eelco Chaudron <[email protected]>

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to