On 10/24/24 14:11, Eelco Chaudron wrote:
>
>
> On 24 Oct 2024, at 13:07, Ilya Maximets wrote:
>
>> On 10/23/24 15:38, Eelco Chaudron wrote:
>>>
>>>
>>> On 21 Oct 2024, at 21:23, Ilya Maximets wrote:
>>>
>>>> Add ovs-fowviz dependencies as suggestions so it is easier to get
>>>> them installed.
>>>>
>>>> Signed-off-by: Ilya Maximets <[email protected]>
>>>
>>> The changes look good to me. Just a small nit below.
>>>
>>> Acked-by: Eelco Chaudron <[email protected]>
>>>
>>>> ---
>>>> debian/control.in | 3 +++
>>>> rhel/openvswitch-fedora.spec.in | 1 +
>>>> 2 files changed, 4 insertions(+)
>>>>
>>>> diff --git a/debian/control.in b/debian/control.in
>>>> index f9eea897e..6737672d1 100644
>>>> --- a/debian/control.in
>>>> +++ b/debian/control.in
>>>> @@ -285,8 +285,11 @@ Depends:
>>>> ${python3:Depends},
>>>> ${shlibs:Depends},
>>>> Suggests:
>>>> + python3-click,
>>>> + python3-graphviz,
>>>> python3-netaddr,
>>>> python3-pyparsing,
>>>> + python3-rich,
>>>> python3-unbound,
>>>> Description: Python 3 bindings for Open vSwitch
>>>> Open vSwitch is a production quality, multilayer, software-based,
>>>> diff --git a/rhel/openvswitch-fedora.spec.in
>>>> b/rhel/openvswitch-fedora.spec.in
>>>> index 00412020a..1706d65b2 100644
>>>> --- a/rhel/openvswitch-fedora.spec.in
>>>> +++ b/rhel/openvswitch-fedora.spec.in
>>>> @@ -119,6 +119,7 @@ License: ASL 2.0
>>>> BuildArch: noarch
>>>> Requires: python3
>>>> Suggests: python3-netaddr python3-pyparsing python3-unbound
>>>> +Suggests: python3-click python3-graphviz python3-rich
>>>
>>> nit: As we have not released this yet, we might as well have all the
>>> Suggests in alphabetical order.
>>
>> Do you mean something like this:
>>
>> Suggests: python3-click
>> Suggests: python3-graphviz
>> Suggests: python3-netaddr
>> Suggests: python3-pyparsing
>> Suggests: python3-rich
>> Suggests: python3-unbound
>
> Guess I should have been more clear, or add an example. So here we go:
>
> Suggests: python3-click python3-graphviz python3-netaddr
> Suggests: python3-pyparsing python3-rich python3-unbound
>
Hmm, I'm not sure there is a value of reordering this way, unless we
list one package per line.
Groups of 3 make sense if they are logically grouped together, e.g.
a group of flowviz dependencies + a group of other dependencies.
So, I'd suggest either:
A)
# DNS resolution support in Python IDL.
Suggests: python3-unbound
# Dependencies of ovs.flow library.
Suggests: python3-netaddr python3-pyparsing
# Dependencies of ovs-flowviz.
Suggests: python3-click python3-graphviz python3-rich
B) Or list one per line.
C) Or keep as is in this patch.
What do you think?
> //Eelco
>
>>>> %{?python_provide:%python_provide python3-openvswitch =
>>>> %{version}-%{release}}
>>>>
>>>> %description -n python3-openvswitch
>>>> --
>>>> 2.46.0
>>>
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
