On 18 Dec 2024, at 20:12, Frode Nordahl wrote:

> Before this change the struct route_data rtm_dst_len element was
> stored as a value that could be fed directly into ipv6_create_mask.
>
> As we prepare for external consumption of this structure this comes
> across as unexpected, as anyone interacting with this code would
> expect the element to behave like the well known kernel rtmsg UAPI.
>
> Delay conversion of IPv4 prefix length until passing this value to
> ovs_router_insert().
>
> Suggested-by: Felix Huettner <[email protected]>
> Signed-off-by: Frode Nordahl <[email protected]>

This patch looks good to me.

Acked-by: Eelco Chaudron <[email protected]>

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to