On Fri, Jan 3, 2025 at 6:04 PM Eelco Chaudron <[email protected]> wrote:
>
> On 18 Dec 2024, at 20:12, Frode Nordahl wrote:
>
> > The route-table code is useful outside the scope of Open vSwitch.
> > In a subsequent patch we will expose the route-table data
> > structures to allow projects compiling against the private Open
> > vSwitch library to consume this data.
> >
> > The rtnetlink rtmsg rtm_table variable can hold route table IDs no
> > higher than UCHAR_MAX.
> >
> > Use the rtnetlink RTA_TABLE route attribute for table IDs larger
> > than UCHAR_MAX, which can represent a 32 bit integer worth of
> > route tables.
> >
> > Signed-off-by: Frode Nordahl <[email protected]>
>
> Should we add some of the earlier discussion to the commit message? 
> Especially the part that the RTA_TABLE attribute is supported from 2.6.

Good idea, done.

> Also, we might need a unit test for this. I guess it can be added to patch 15.

Ack, there is one route table test there, but it does indeed need to
be extended to include table numbers > UCHAR_MAX.

--
Frode Nordahl

> The patch itself looks good to me.
>
> Cheers,
>
> Eelco
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to