On Wed, Feb 05, 2025 at 03:13:57PM +0100, Dumitru Ceara wrote: > On 2/4/25 2:59 PM, Felix Huettner via dev wrote: > > This allows the ovn-controller to later find all ports that > > participate in dynamic routing. > > > > Signed-off-by: Felix Huettner <[email protected]> > > --- > > Hi Felix, > > > v5->v6: > > * addressed review comments > > v4->v5: skipped > > v2->v3: > > * A lot of minor review comments. > > * Added more documentation and news > > > > NEWS | 8 ++++++++ > > northd/northd.c | 20 ++++++++++++++++++++ > > ovn-nb.xml | 41 +++++++++++++++++++++++++++++++++++++++++ > > tests/ovn-northd.at | 31 +++++++++++++++++++++++++++++++ > > 4 files changed, 100 insertions(+) > > > > [...] > > > diff --git a/northd/northd.c b/northd/northd.c > > index 3f14cc75c..573d3cb24 100644 > > --- a/northd/northd.c > > +++ b/northd/northd.c > > @@ -4111,6 +4111,26 @@ sync_pb_for_lrp(struct ovn_port *op, > > } > > } > > > > + if (is_cr_port(op) || chassis_name) { > > + if (op->od->dynamic_routing) { > > I think Lorenzo suggested merging these two conditions to reduce the > indentation depth. > > With that addressed, feel free to add my ack to v7: > Acked-by: Dumitru Ceara <[email protected]>
Thanks a lot, will be fixed. Felix > > Thanks, > Dumitru > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
