On 2/4/25 2:59 PM, Felix Huettner via dev wrote: > Learned routes must be bound to a lrp on which the routes where learned. > In case the lrp is deleted for whatever reason no ovn-controller would > clean these routes up, therefor we do this in northd. > > Acked-by: Dumitru Ceara <[email protected]> > Signed-off-by: Felix Huettner <[email protected]> > --- > v5->v6: > * addressed review comments > v4->v5: skipped > v2->v3: > * A lot of minor review comments. > > northd/en-learned-route-sync.c | 8 +++++++- > northd/northd.c | 12 ++++++------ > tests/ovn-northd.at | 16 ++++++++++++++++ > 3 files changed, 29 insertions(+), 7 deletions(-) > > diff --git a/northd/en-learned-route-sync.c b/northd/en-learned-route-sync.c > index 49780de39..d0cd73092 100644 > --- a/northd/en-learned-route-sync.c > +++ b/northd/en-learned-route-sync.c > @@ -193,7 +193,13 @@ routes_table_sync( > struct hmap *parsed_routes_out) > { > const struct sbrec_learned_route *sb_route; > - SBREC_LEARNED_ROUTE_TABLE_FOR_EACH (sb_route, sbrec_learned_route_table) > { > + SBREC_LEARNED_ROUTE_TABLE_FOR_EACH_SAFE (sb_route, > + sbrec_learned_route_table) { > + if (!ovn_port_find(lr_ports, > + sb_route->logical_port->logical_port)) {
This fits on a single line. The rest still looks OK so feel free to keep my ack on this patch in v7. Thanks, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
