On 2/4/25 3:00 PM, Felix Huettner via dev wrote:
> When we stop ovn-controller without immediately restarting it we now
> cleanup routes.
> This allows the routing agents to stop advertising this chassis to the
> fabric.
>
> Signed-off-by: Felix Huettner <[email protected]>
> ---
Hi Felix,
> v5->v6:
> * addressed review comments
> * fixed testcase to cleanup all vrfs
> v3->v4:
> - addressed review comments.
>
> controller/route-exchange-netlink.c | 32 +++++++++---
> controller/route-exchange-netlink.h | 2 +
> controller/route-exchange.c | 67 +++++++++++++++++++++++-
> tests/system-ovn.at | 81 +++++++++++++++++++++++++++++
> 4 files changed, 174 insertions(+), 8 deletions(-)
[...]
> +
> +static void
> +maintained_route_table_add(uint32_t table_id)
> +{
> + if (maintained_route_table_contains(table_id)) {
> + return;
> + }
> + uint32_t hash = maintained_route_table_hash(table_id);
> + struct maintained_route_table_entry *mrt = xzalloc(sizeof(*mrt));
We can use xmalloc().
Please use "sizeof *mrt" instead of "sizeof(*mrt)".
The rest looks ok to me. With the above addressed, feel free to add my
ack to v7:
Acked-by: Dumitru Ceara <[email protected]>
Thanks,
Dumitru
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
