On Wed, Feb 05, 2025 at 04:03:50PM +0100, Dumitru Ceara wrote: > On 2/4/25 2:59 PM, Felix Huettner via dev wrote: > > We now learn all routes inside the vrfs we also advertise routes on. > > The routes are then placed in the southbound database for processing by > > northd. > > > > Routes are only selected if matching the following rules: > > 1. must not be a route advertised by us > > 2. must not be a local connected route (as we want to not learn transfer > > networks) > > 3. the prefix must not be a link local address > > > > However we can not reliably determine over which link we learned the > > route in case we have two LRPs of the same LR on the same chassis. > > For now we just assume the routes on both links are identical. > > Future commits will refine this. > > > > Signed-off-by: Felix Huettner <[email protected]> > > --- > > Hi Felix, > > > v5->v6: > > * addressed review comments > > v3->v4: > > - addressed review comments. > > v2->v3: > > * Set monitor conditions on sb Learned_Route table. > > * Do not learn routes if Learned_Route table does not exist (upgrades). > > > > controller/ovn-controller.c | 67 ++++++++++++-- > > controller/route-exchange-netlink.c | 38 +++++++- > > controller/route-exchange-netlink.h | 15 +++- > > controller/route-exchange.c | 135 +++++++++++++++++++++++++++- > > controller/route-exchange.h | 3 + > > lib/ovn-util.c | 10 +++ > > lib/ovn-util.h | 1 + > > tests/system-ovn.at | 21 +++++ > > 8 files changed, 275 insertions(+), 15 deletions(-) > > [...] > > > @@ -5122,9 +5160,11 @@ en_route_exchange_run(struct engine_node *node, void > > *data OVS_UNUSED) > > > > static void * > > en_route_exchange_init(struct engine_node *node OVS_UNUSED, > > - struct engine_arg *arg OVS_UNUSED) > > + struct engine_arg *arg) > > { > > - return NULL; > > + struct ed_type_route_exchange *re = xzalloc(sizeof(*re)); > > Please use "sizeof *re" instead. Also, xmalloc() should be enough. > > With that addressed, feel free to add my ack to v7: > Acked-by: Dumitru Ceara <[email protected]>
Hi Dumitru, thanks a lot. Will change it in v7. Thanks, Felix > > Thanks, > Dumitru > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
