On 2/17/25 12:05, Xavier Simonart wrote: > Default lease file for dhcp varies between OSes. For instance, > /var/lib/dhcp/dhcpd6.leases or /var/lib/dhcpd/dhcpd6.leases might be used. > Before this patch, lease file was not deleted on some OSes, resulting in > potential test failures (e.g. when multiple prefix delgation tests were > executed within a certain time). > > Signed-off-by: Xavier Simonart <[email protected]> > --- > tests/system-common-macros.at | 34 +++++++++++++++++++++++++--------- > tests/system-ovn.at | 12 +++--------- > 2 files changed, 28 insertions(+), 18 deletions(-) > > diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at > index 72ff6bdfc..0b32bb597 100644 > --- a/tests/system-common-macros.at > +++ b/tests/system-common-macros.at > @@ -293,6 +293,27 @@ m4_define([NETNS_START_TCPDUMP], > ] > ) > > +# NETNS_START_DHCPD([namespace], [iface], [dhcpd.conf]) > +# > +# Helper to properly start dhcpd > +m4_define([NETNS_START_DHCPD], > + [ > + DHCP_TEST_DIR="/tmp/dhcp-test"
Not a full review, but I'd suggest to just create a sub-directory of the current test directory instead of polluting global /tmp. This way you'll not need to worry about removing it and it will also be part of the test log archive in case of any failures. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
