On 2/25/25 2:47 PM, Felix Huettner wrote:
> On Tue, Feb 25, 2025 at 02:31:51PM +0100, Dumitru Ceara wrote:
>> On 2/25/25 2:10 PM, Dumitru Ceara wrote:
>>> On 2/25/25 1:42 PM, Felix Huettner wrote:
>>>> On Tue, Feb 25, 2025 at 12:01:20AM +0100, Dumitru Ceara wrote:
>>>>> It makes more sense to make these static (internal) in the module where
>>>>> they're actually used. They use "public" APIs to add advertised dynamic
>>>>> routes.
>>>>>
>>>>> Fixes: cd4ad2f56179 ("northd: Redistribution of NAT/LB routes.")
>>>>> Signed-off-by: Dumitru Ceara <dce...@redhat.com>
>>>>
>>>> Hi Dumitru,
>>>>
>>>
>>> Hi Felix,
>>>
>>>> i am not sure if we should continue with having en_dynamic_routes inside
>>>> the
>>>> en-advertised-route-sync.* files. Maybe based on the other engine nodes
>>>> we should split it out to a separate file?
>>>>
>>>
>>> Makes sense, I'll do that in v2.
>>>
>>
>> Actually, on second thought, would you mind if I do that as a follow up,
>> only on main? I'd like to minimize the change we're backporting to 25.03.
>
> Hi Dumitru,
>
> if we want to have that in 25.03 then i am completely fine with as it is
> right now.
>
> Acked-by: Felix Huettner <felix.huettner@stackit.cloud>
>
Thanks, Felix and Martin! Felix, I'll add your ack to this patch in v2.
I'll respin the patchset (without the first two patches that I already
applied) soon.
Regards,
Dumitru
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
