Hi Ilya,

On 2/26/25 4:28 PM, Ilya Maximets wrote:
> On 2/26/25 15:44, Ilya Maximets wrote:
>> A peer of a switch can be another switch, so the port type has to be
>> checked.  The missing check doesn't seem to lead to crashes, but it
>> leads to addresses of switch-switch ports not being advertised.
>>
>> Fix that by checking the port type instead of assuming.
>>

Thanks for the fix!  And thanks, Felix, for reviewing it!

>> The issue is a result of two features being developed at the same time
>> and the code not being re-checked before merging the routing patches.
> 

Bugs sometimes make it through unfortunately.  It's great it was caught
early, before the release!

> This last part may sound wrong, sorry about that.  Just wanted to highlight
> the way the issue was introduced.  Not anybody's fault for sure.  May be cut
> out of the commit message before applying.
> 

OK, thanks for the follow up!  I removed this last part of the commit
message and applied the patch to main and 25.03.

> Best regards, Ilya Maximets.
> 

Regards,
Dumitru

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to