On 3/1/25 2:48 PM, Frank Wagner wrote: > This patch is the first in a series of patches to make ovn > buildable on Windows again. > This patch includes the OVS sources and removes leftovers from the > original OVS build system. > > Signed-off-by: Frank Wagner <frank.wag...@dbosoft.eu> > > ---
Hi Frank, Thanks for the patch! CC: Ilya and Alin. It would be nice if we could enable Windows builds in CI for OVN too. I know OVS does that. I'd need some help with setting that up though. Aside from the fact that it would help reviewers compile-test Windows changes (I don't really know how to do that for example) it would also ensure that OVN builds don't break on Windows in the future. What do you guys think? Thanks, Dumitru > Makefile.am | 31 ++----------------------------- > 1 file changed, 2 insertions(+), 29 deletions(-) > > diff --git a/Makefile.am b/Makefile.am > index 6b0f1913a..d8a0be4a9 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -23,6 +23,8 @@ AM_CPPFLAGS += -I $(top_srcdir)/include > > if WIN32 > AM_CPPFLAGS += $(PTHREAD_INCLUDES) > +AM_CPPFLAGS += -I $(OVS_SRCDIR)/include/windows > +AM_CPPFLAGS += -I $(OVS_SRCDIR)/datapath-windows/include > AM_CPPFLAGS += $(MSVC_CFLAGS) > AM_LDFLAGS += $(PTHREAD_LDFLAGS) > AM_LDFLAGS += $(MSVC64_LDFLAGS) > @@ -434,35 +436,6 @@ $(srcdir)/manpages.mk: $(MAN_ROOTS) > build-aux/sodepends.py $(OVS_SRCDIR)/python/ > fi > CLEANFILES += manpage-dep-check > > -if VSTUDIO_DDK > -ALL_LOCAL += ovsext > -ARCH = x64 > -ovsext: datapath-windows/ovsext.sln > $(srcdir)/datapath-windows/include/OvsDpInterface.h > -if VSTUDIO_WIN8 > - MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln > /target:Build /property:Configuration="Win8$(VSTUDIO_CONFIG)" > /property:Version="$(PACKAGE_VERSION)" //p:Platform=$(ARCH) > -endif > -if VSTUDIO_WIN8_1 > - MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln > /target:Build /property:Configuration="Win8.1$(VSTUDIO_CONFIG)" > /property:Version="$(PACKAGE_VERSION)" //p:Platform=$(ARCH) > -endif > -if VSTUDIO_WIN10 > - MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln > /target:Build /property:Configuration="Win10$(VSTUDIO_CONFIG)" > /property:Version="$(PACKAGE_VERSION)" //p:Platform=$(ARCH) > -endif > - > - > -CLEAN_LOCAL += ovsext_clean > -ovsext_clean: datapath-windows/ovsext.sln > -if VSTUDIO_WIN8 > - MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln > /target:Clean /property:Configuration="Win8$(VSTUDIO_CONFIG)" > /property:Version="$(PACKAGE_VERSION)" //p:Platform=$(ARCH) > -endif > -if VSTUDIO_WIN8_1 > - MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln > /target:Clean /property:Configuration="Win8.1$(VSTUDIO_CONFIG)" > /property:Version="$(PACKAGE_VERSION)" //p:Platform=$(ARCH) > -endif > -if VSTUDIO_WIN10 > - MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln > /target:Clean /property:Configuration="Win10$(VSTUDIO_CONFIG)" > /property:Version="$(PACKAGE_VERSION)" //p:Platform=$(ARCH) > -endif > -endif > -.PHONY: ovsext > - > clang-analyze: clean > @which clang scan-build >/dev/null 2>&1 || \ > (echo "Unable to find clang/scan-build, Install clang,clang-analyzer > packages"; exit 1) _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
