Totally agree with CI, I have not added it to the patches, but this repo builds it with a github workflow:
https://github.com/dbosoft/ovn We use OVN for eryph (https://www.eryph.io), so at least for our use case we will keep it maintained for Windows but would like to see our work go upstream for use by all. Most of the changes are really just ports back from OVS and some cleanup from the split. >From a quality and feature perspective - absolutely agree and we hope to >change that in the next few years and keep Windows up to date. I have also >recently submitted some other patches to OVS on Windows. ________________________________ Von: Dumitru Ceara <dce...@redhat.com> Gesendet: Donnerstag, 6. März 2025 15:28 An: Ilya Maximets <i.maxim...@ovn.org>; Frank Wagner <frank.wag...@dbosoft.eu>; d...@openvswitch.org <d...@openvswitch.org> Cc: Mark Michelson <mmich...@redhat.com>; Numan Siddique <num...@ovn.org>; Han Zhou <hz...@ovn.org> Betreff: Re: [ovs-dev] [PATCH ovn 1/10] windows: Include OVS sources. + other OVN maintainers On 3/6/25 2:42 PM, Ilya Maximets wrote: > On 3/6/25 12:20, Dumitru Ceara wrote: >> On 3/1/25 2:48 PM, Frank Wagner wrote: >>> This patch is the first in a series of patches to make ovn >>> buildable on Windows again. >>> This patch includes the OVS sources and removes leftovers from the >>> original OVS build system. >>> >>> Signed-off-by: Frank Wagner <frank.wag...@dbosoft.eu> >>> >>> --- >> >> Hi Frank, >> >> Thanks for the patch! >> >> CC: Ilya and Alin. >> >> It would be nice if we could enable Windows builds in CI for OVN too. I >> know OVS does that. I'd need some help with setting that up though. >> >> Aside from the fact that it would help reviewers compile-test Windows >> changes (I don't really know how to do that for example) it would also >> ensure that OVN builds don't break on Windows in the future. >> >> What do you guys think? > > The CI, I think, is necessary if we want to ensure the build will not > break in the future. It should be possible to copy what we do in OVS > with appveyor or make an equivalent GHA job now that GHA supports windows > builds and OVN doesn't really need to build the kernel datapath driver. > > However, ... > > It appears that the windows build was broken pretty much after the split, > which was many years ago, and there were no complains about that so far. > So, I guess, it's pretty safe to say that OVN usage on windows wasn't > actually a thing. Also, I'm pretty sure that many OVN features will just > not work on Windows due to missing support of certain actions in the > windows datapath implementation as well as direct use of some Linux-specific > kernel APIs from the ovn-controller. Documentation for the OVN on windows > also doesn't really exist, there is a page for it, but it's empty. > And OVN doesn't have a way to generate a windows installer package, so the > only way to install it is from sources. > > On OVS side the windows datapath development have stagnated. There are > many known issues and the last time a feature was added was in 2022, even > though this datapath implementation is missing a lot of features in > comparison to others. I'm not sure if it will see a revival or we'll > need to deprecate it in the end. > > Saying that, I think, we should also consider a question if OVN should > actually support windows builds in the first place. If the answer is > "yes", then we need a proper CI setup and the documentation update on how > to install and use it as well as list of features that are not supported. There clearly are some users (maybe not on recent OVN versions but still). It's hard to tell how many there are in total though. > If the answer is "no", then we should remove the remaining broken bits > instead. > > Thoughts? > We're likely in the same position with the OSX builds - we currently compile for OSX in CI but we don't run any tests on OSX. We also have no docs for OSX as far as I can tell. >From my perspective, I'd be fine with a similar CI job that compiles on Windows. It just depends how much effort that implies. Regardless of the choice we make, we should probably update our docs for both OSX and Windows. Regards, Dumitru _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
