On 3/9/25 3:46 PM, Sebastian Andrzej Siewior wrote:
> exec_actions_level is a per-CPU integer allocated at compile time.
> action_fifos and flow_keys are per-CPU pointer and have their data
> allocated at module init time.
> There is no gain in splitting it, once the module is allocated, the
> structures are allocated.
>
> Merge the three per-CPU variables into ovs_action, adapt callers.
>
> Cc: Pravin B Shelar <pshe...@ovn.org>
> Cc: d...@openvswitch.org
> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de>
> ---
> net/openvswitch/actions.c | 49 +++++++++++++-------------------------
> net/openvswitch/datapath.c | 9 +------
> net/openvswitch/datapath.h | 3 ---
> 3 files changed, 17 insertions(+), 44 deletions(-)
>
> diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c
> index 704c858cf2093..322ca7b30c3bc 100644
> --- a/net/openvswitch/actions.c
> +++ b/net/openvswitch/actions.c
> @@ -78,17 +78,22 @@ struct action_flow_keys {
> struct sw_flow_key key[OVS_DEFERRED_ACTION_THRESHOLD];
> };
>
> -static struct action_fifo __percpu *action_fifos;
> -static struct action_flow_keys __percpu *flow_keys;
> -static DEFINE_PER_CPU(int, exec_actions_level);
> +struct ovs_action {
> + struct action_fifo action_fifos;
> + struct action_flow_keys flow_keys;
> + int exec_level;
> +};
I have the feeling this is not a very good name, as 'OVS action' has a
quite specific meaning, not really matched here.
Also more OVS people, as Pravin is not really active anymore.
Thanks,
Paolo
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
