On 3/18/25 11:32, Dumitru Ceara wrote: > On 3/18/25 11:26 AM, Aleksandr Smirnov (K2 Cloud) wrote: >> Hi guys, >> > > Hi Alexander, > >> Could I kindly ask you not to bring to C-language comments any unnatural >> meaning? >> I mean let's keep comments as just comments. You can move 'cksum = NNN' >> away from >> comment to other entity like static variable with cost of few bytes or >> even #define that >> will cost you nothing. >> > > That's a fair ask, a #define is OK from my perspective.
Hmm. The point of having this checksum in the comment that belongs to the version definition is to create a strong relation between them. If we create a separate define, we'll need to add another comment to it explaining that if this is changed than the version change should be considered. And we already have this for the pipeline stages and the actions and it doesn't really work. Closer we have it, more chances for it to be noticed in review. What exactly the point of not having the checksum in the comment? We sum some text and then grep it out as text. At no point this checksum is a structured data or part of the language construct. AFAICT, we will lose on clarity, but I'm not sure what we'll gain. FWIW, comments are used for code generation in other places, e.g. OpenFlow fields. Best regards, Ilya Maximets. > >> Thank you, >> >> Alexander >> > > Regards, > Dumitru _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
