On 3/20/25 3:32 PM, Ilya Maximets wrote: > On 3/18/25 10:29, Dumitru Ceara wrote: >> >> Can we enhance checkpatch.py to warn if the patch diff contains a >> checksum value change but doesn't contain an OVN_INTERNAL_MINOR_VER >> change? It will generate false positives when pipeline changes are >> cosmetic/minor but it will be the responsibility of the committers to >> waive/ignore those. > > It might be a good thing to add, but it may be a little tricky to implement. > Checkpatch is mostly stateless today and checks lines one by one. >
OK, let's leave it for now, I guess. > >> We need to increment OVN_INTERNAL_MINOR_VER also whenever any existing >> OVNACT is updated (see the comment in actions.h). Should we compute the >> checksum of OVNACT rows too? That might be a bit trickier though.. >> >> * These OVNACTS are used to generate the OVN internal version. See >> * ovn_get_internal_version() in lib/ovn-util.c. If any OVNACT is updated, >> * increment the OVN_INTERNAL_MINOR_VER macro in lib/ovn-util.c. >> >> Any thoughts on this, Alexandra, Ilya, Vladislav? > > I guess, we may hash everything between 'List of OVN logical actions.' > and the '/* Header. */'. Or maybe add a special comment as a hash marker. > That's a good idea. Let's try to do that. Alexandra, what do you think? Thanks, Dumitru _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
