On Tue, May 13, 2025 at 3:43 PM Eelco Chaudron <echau...@redhat.com> wrote:

>
>
> On 13 May 2025, at 15:17, Ilya Maximets wrote:
>
> > On two separate occasions GitHub added random garbage into the hosts
> > file breaking our tests.  This change adds a permanent workaround for
> > this kind of stuff.  It will remove everything that doesn't look like
> > a correct syntax from the file.
> >
> > The regex is not perfect, but it should be sufficient for most cases.
> > It allows empty lines, comments and a valid 'IP NAME[ NAME]...' lines,
> > where 'IP' resembles an IP address and the 'NAME' consists of valid
> > DNS characters.  Under normal conditions the diff should always be
> > empty.
> >
> > Signed-off-by: Ilya Maximets <i.maxim...@ovn.org>
>
> The change looks good to me. Tested through GitHub ;)
>
> Acked-by: Eelco Chaudron <echau...@redhat.com>
>
>
Looks good to me, thanks.

Acked-by: Ales Musil <amu...@redhat.com>

I will send the OVN version of this patch for review soon.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to