On 5/13/25 4:35 PM, Dumitru Ceara wrote:
> Hi Ilya, Eelco,
> 
> On 5/13/25 3:43 PM, Eelco Chaudron wrote:
>>
>>
>> On 13 May 2025, at 15:17, Ilya Maximets wrote:
>>
>>> On two separate occasions GitHub added random garbage into the hosts
>>> file breaking our tests.  This change adds a permanent workaround for
>>> this kind of stuff.  It will remove everything that doesn't look like
>>> a correct syntax from the file.
>>>
>>> The regex is not perfect, but it should be sufficient for most cases.
>>> It allows empty lines, comments and a valid 'IP NAME[ NAME]...' lines,
>>> where 'IP' resembles an IP address and the 'NAME' consists of valid
>>> DNS characters.  Under normal conditions the diff should always be
>>> empty.
>>>
>>> Signed-off-by: Ilya Maximets <i.maxim...@ovn.org>
>>
>> The change looks good to me. Tested through GitHub ;)
>>
>> Acked-by: Eelco Chaudron <echau...@redhat.com>
>>
> 
> Also tested in the ovn-org/ovn repo through a PR:
> https://github.com/ovn-org/ovn/actions/runs/14998350287
> 
> Acked-by: Dumitru Ceara <dce...@redhat.com>
> 
> Regards,
> Dumitru
> 

Thanks, Eelco, Ales and Dumitru!

Applied to all supported branches down to 3.2.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to