This is not a real issue, as the initializer function,
rewrite_flow_push_nsh(), ensures it returns NULL on error.
However, cleaning this up improves code clarity and resolves
a Coverity warning about a potential memory leak.
Signed-off-by: Eelco Chaudron <echau...@redhat.com>
---
ofproto/ofproto-dpif-xlate.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
index c8c3b1210..2c8197fb7 100644
--- a/ofproto/ofproto-dpif-xlate.c
+++ b/ofproto/ofproto-dpif-xlate.c
@@ -7055,6 +7055,8 @@ xlate_generic_encap_action(struct xlate_ctx *ctx,
/* The actual encap datapath action will be generated at next commit.
*/
ctx->pending_encap = true;
ctx->encap_data = encap_data;
+ } else {
+ ofpbuf_delete(encap_data);
}
}
--
2.49.0
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
