Re: [ovs-dev] [PATCH 3/7] ofproto-dpif-upcall: Check odp_tun_key_from_attr() return value.

[Eelco Chaudron via dev]

On 5 Jun 2025, at 18:39, Aaron Conole wrote:

> Eelco Chaudron via dev <ovs-dev@openvswitch.org> writes:
>
>> In the IPFIX and flow sample upcall handling, check the validity
>> of the tunnel key returned by odp_tun_key_from_attr(). If the
>> tunnel key is invalid, return an error.
>>
>> his was reported by Coverity, but the change also improves
>
>   ^ = This
>
> Can probably be fixed on apply.
>
>> robustness and avoids undefined behavior in the case of malformed
>> tunnel attributes.
>>
>> Fixes: 8b7ea2d48033 ("Extend OVS IPFIX exporter to export tunnel headers")
>> Signed-off-by: Eelco Chaudron <echau...@redhat.com>
>> ---
>
> Acked-by: Aaron Conole <acon...@redhat.com>

Thanks for the review Aaron! Applied to main with the commit message change.

//Eelco

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev