On 8/20/25 12:21 PM, Dumitru Ceara wrote:
> On 8/20/25 5:31 AM, Sragdhara Datta Chaudhuri wrote:
>> Hi Numan,
>>
>>  
> 
> Hi Sragdhara, Numan,
> 
>>
>> Have sent out patch version 6. Would be great if the feature can be
>> included in 25.09.
>>
> 
> Unfortunately, patch 3/5 doesn't apply correctly so the robot cannot run
> CI on it (and the rest of the series):
> 
> https://patchwork.ozlabs.org/project/ovn/patch/20250820012537.15761-4-sragdha.chau...@nutanix.com/
> 
> I'll try to rebase it myself and push it to my fork but it might be good
> to just send a v7 that's rebased on the most recent main branch anyway.
> 

I rebased the series on top of the current main branch and pushed it here:

https://github.com/dceara/ovn/tree/refs/heads/review-pws469954-network-func-insertion-v6

I didn't do more than just "compile-test" it locally though.  CI is
currently running here:
https://github.com/dceara/ovn/actions/runs/17098990906
https://github.com/dceara/ovn/actions/runs/17098990533

>>  
>>
>> Thanks,
>>
>> Sragdhara
>>
>>  
>>
>> *From: *Sragdhara Datta Chaudhuri <sragdha.chau...@nutanix.com>
>> *Date: *Tuesday, August 19, 2025 at 2:57 PM
>> *To: *Numan Siddique <num...@ovn.org>
>> *Cc: *ovs-dev@openvswitch.org <ovs-dev@openvswitch.org>, Dumitru Ceara
>> <dce...@redhat.com>, Mark Michelson <mmich...@redhat.com>, Ales Musil
>> <amu...@redhat.com>, Han Zhou <hz...@ovn.org>
>> *Subject: *Re: [ovs-dev] [PATCH OVN v5 0/5] Network Function Insertion.
>>
>> Hi Numan,
>>
>>  
>>
>> Thanks a lot for taking time to review the patches. I have addressed
>> your comments. It is taking some time because I had missed out adding
>> changes in northd.xml. Should be able to send it out by today.
>>
>> By the way, while you have acked patch 1, 2, 3 and 5, the review on
>> patch 4 is still pending.
>>
>>  
>>
> 
> [...]
> 
>>
>>
>> Hi Sragdhara,
>>
>> Do you plan to address the comments and submit v6 ?
>>
>> I guess we can still consider this series for 25.09 if you can quickly
>> spin a new version.
>>
> 
> Officially, we're passed branching, so we should not be merging new
> features.
> 
>> I've acked patches 1-4 (with minor comments) and have some comments
>> for patch 6.  If its not possible to address the comments for patch 6,
>> perhaps I can merge patches 1-5 after addressing the minor comments.
>>
> 
> However, patches 1, 2, 3 have been acked by Numan on July 30th (way
> before branching); the comment from Numan on patch 5 was to add some
> more tests and I don't see a patch 6.
> 
> Numan, did you mean "merge 1-4 and work on patch 5 later"?
> 
> What about patch 4, as Sragdhara mentions, it didn't have an ack from
> you?  Did that look OK to you but you maybe forgot to ack it?
> 
>> @Dumitru Ceara @Mark Michelson @Ales Musil @Han Zhou  any objections
>> here ?  Since this patch series is on review for a long time, I think
>> it can be considered if there are no major concerns to the quality of
>> the code.
>>
> 
> This functionality has been long in the making and, if we get
> confirmation from Numan that the intention was to accept the form it had
> in v5 (with minimal changes), then I'm probably OK with trying to get it
> in now, after branching.  But, as this is an exception to our usual
> process, I'd love to hear from the other maintainers too, if possible.
> 
> I'll have another look at v6 (or v7 if Sragdhara finds some time to
> rebase it soon).
> 
>> Numan
>>
>>>
> 
> Regards,
> Dumitru
> 

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to