Thanks Dumitru. I’ll try to send a patch7 today after rebase. Sragdhara
From: Dumitru Ceara <dce...@redhat.com> Date: Wednesday, August 20, 2025 at 5:56 AM To: Sragdhara Datta Chaudhuri <sragdha.chau...@nutanix.com>, Numan Siddique <num...@ovn.org> Cc: ovs-dev@openvswitch.org <ovs-dev@openvswitch.org>, Mark Michelson <mmich...@redhat.com>, Ales Musil <amu...@redhat.com>, Han Zhou <hz...@ovn.org> Subject: Re: [ovs-dev] [PATCH OVN v5 0/5] Network Function Insertion. !-------------------------------------------------------------------| CAUTION: External Email |-------------------------------------------------------------------! On 8/20/25 12:21 PM, Dumitru Ceara wrote: > On 8/20/25 5:31 AM, Sragdhara Datta Chaudhuri wrote: >> Hi Numan, >> >> > > Hi Sragdhara, Numan, > >> >> Have sent out patch version 6. Would be great if the feature can be >> included in 25.09. >> > > Unfortunately, patch 3/5 doesn't apply correctly so the robot cannot run > CI on it (and the rest of the series): > > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_project_ovn_patch_20250820012537.15761-2D4-2Dsragdha.chaudhu-40nutanix.com_&d=DwIDaQ&c=s883GpUCOChKOHiocYtGcg&r=uXnTjPDrt8WYa8nbZqANTqL0TyzFTTKpPHphGFPgvBw&m=aExnmBvrUSdjyTca2Na37CeW_wbkj2Ig2u5kHavV_qZ9cGX_JmwjVW_R5WNlSdKI&s=Epjedr1hMWmd_v9-ikLtqXSCoSFGwxZvAeBe8CV3Dqk&e= > > I'll try to rebase it myself and push it to my fork but it might be good > to just send a v7 that's rebased on the most recent main branch anyway. > I rebased the series on top of the current main branch and pushed it here: https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_dceara_ovn_tree_refs_heads_review-2Dpws469954-2Dnetwork-2Dfunc-2Dinsertion-2Dv6&d=DwIDaQ&c=s883GpUCOChKOHiocYtGcg&r=uXnTjPDrt8WYa8nbZqANTqL0TyzFTTKpPHphGFPgvBw&m=aExnmBvrUSdjyTca2Na37CeW_wbkj2Ig2u5kHavV_qZ9cGX_JmwjVW_R5WNlSdKI&s=ttRn8Mbx9Nfwvrj3wByYn3rgpldD_b2XZUob0ZDPU5M&e= I didn't do more than just "compile-test" it locally though. CI is currently running here: https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_dceara_ovn_actions_runs_17098990906&d=DwIDaQ&c=s883GpUCOChKOHiocYtGcg&r=uXnTjPDrt8WYa8nbZqANTqL0TyzFTTKpPHphGFPgvBw&m=aExnmBvrUSdjyTca2Na37CeW_wbkj2Ig2u5kHavV_qZ9cGX_JmwjVW_R5WNlSdKI&s=N-HC9kJMQDF5XcAnh67-XM4Aiy5L2UtI3rhWCDBNEsQ&e= https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_dceara_ovn_actions_runs_17098990533&d=DwIDaQ&c=s883GpUCOChKOHiocYtGcg&r=uXnTjPDrt8WYa8nbZqANTqL0TyzFTTKpPHphGFPgvBw&m=aExnmBvrUSdjyTca2Na37CeW_wbkj2Ig2u5kHavV_qZ9cGX_JmwjVW_R5WNlSdKI&s=OK62m8SmHBZozENHZx3VmyzMdOuvP5esyTtDZdqXOkY&e= >> >> >> Thanks, >> >> Sragdhara >> >> >> >> *From: *Sragdhara Datta Chaudhuri <sragdha.chau...@nutanix.com> >> *Date: *Tuesday, August 19, 2025 at 2:57 PM >> *To: *Numan Siddique <num...@ovn.org> >> *Cc: *ovs-dev@openvswitch.org <ovs-dev@openvswitch.org>, Dumitru Ceara >> <dce...@redhat.com>, Mark Michelson <mmich...@redhat.com>, Ales Musil >> <amu...@redhat.com>, Han Zhou <hz...@ovn.org> >> *Subject: *Re: [ovs-dev] [PATCH OVN v5 0/5] Network Function Insertion. >> >> Hi Numan, >> >> >> >> Thanks a lot for taking time to review the patches. I have addressed >> your comments. It is taking some time because I had missed out adding >> changes in northd.xml. Should be able to send it out by today. >> >> By the way, while you have acked patch 1, 2, 3 and 5, the review on >> patch 4 is still pending. >> >> >> > > [...] > >> >> >> Hi Sragdhara, >> >> Do you plan to address the comments and submit v6 ? >> >> I guess we can still consider this series for 25.09 if you can quickly >> spin a new version. >> > > Officially, we're passed branching, so we should not be merging new > features. > >> I've acked patches 1-4 (with minor comments) and have some comments >> for patch 6. If its not possible to address the comments for patch 6, >> perhaps I can merge patches 1-5 after addressing the minor comments. >> > > However, patches 1, 2, 3 have been acked by Numan on July 30th (way > before branching); the comment from Numan on patch 5 was to add some > more tests and I don't see a patch 6. > > Numan, did you mean "merge 1-4 and work on patch 5 later"? > > What about patch 4, as Sragdhara mentions, it didn't have an ack from > you? Did that look OK to you but you maybe forgot to ack it? > >> @Dumitru Ceara @Mark Michelson @Ales Musil @Han Zhou any objections >> here ? Since this patch series is on review for a long time, I think >> it can be considered if there are no major concerns to the quality of >> the code. >> > > This functionality has been long in the making and, if we get > confirmation from Numan that the intention was to accept the form it had > in v5 (with minimal changes), then I'm probably OK with trying to get it > in now, after branching. But, as this is an exception to our usual > process, I'd love to hear from the other maintainers too, if possible. > > I'll have another look at v6 (or v7 if Sragdhara finds some time to > rebase it soon). > >> Numan >> >>> > > Regards, > Dumitru > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
