On 9/1/25 6:16 PM, Ilya Maximets wrote:
> On 9/1/25 6:13 PM, Ilya Maximets wrote:
>> On 9/1/25 1:22 PM, Dumitru Ceara wrote:
>>> The Southbound Static_Mac_Binding table is write-only from ovn-northd
>>> perspective.  Omit alerting for any changes on this table (as we do for
>>> all other write-only tables) in ovn-northd.
>>>
>>> Fixes: b22684d4e37c ("Add a northbound interface to program MAC_Binding 
>>> table")
>>> Signed-off-by: Dumitru Ceara <dce...@redhat.com>
>>> ---
>>>  northd/ovn-northd.c | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
>>> index 62da4a3aad..29152cdd74 100644
>>> --- a/northd/ovn-northd.c
>>> +++ b/northd/ovn-northd.c
>>> @@ -962,6 +962,10 @@ main(int argc, char *argv[])
>>>          ovsdb_idl_omit_alert(ovnsb_idl_loop.idl,
>>>                               &sbrec_advertised_route_columns[i]);
>>>      }
>>> +    for (size_t i = 0; i < SBREC_STATIC_MAC_BINDING_N_COLUMNS; i++) {
>>> +        ovsdb_idl_omit_alert(ovnsb_idl_loop.idl,
>>> +                             &sbrec_static_mac_binding_columns[i]);
>>> +    }
>>>  
>>>      unixctl_command_register("sb-connection-status", "", 0, 0,
>>>                               ovn_conn_show, ovnsb_idl_loop.idl);
>>
>> FWIW, looks like this test breaks the static mac binding garbage collection
> 
> * this change
> 

Ah sorry about that.  I was running CI with Ales' static mac binding fix
applied [0].  I'll repost as v3 when that one is merged and once we
figure out the discussion on patch 2/4.

Regards,
Dumitru

[0]
https://patchwork.ozlabs.org/project/ovn/patch/20250829140636.957700-1-amu...@redhat.com/

>> test in GitHub CI.
>>
>> Best regards, Ilya Maximets.
> 

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to