On Mon, Sep 1, 2025 at 1:22 PM Dumitru Ceara <dce...@redhat.com> wrote:

> This series fixes a few issues uncovered during the 25.09.0 pre-release
> testing:
> - the SB.Datapath_Binding.type schema was not backwards compatible
>   (patch 1/4)
> - the way "old-style" Datapath_Binding records were updated/re-created
>   upon upgrade could cause infinite looping in ovn-northd continuously
>   trying to reconcile the SB contents (patch 2/4)
> - SB.Static_Mac_Binding updates would be processed as change alerts by
>   ovn-northd but that's not really needed because ovn-northd is the only
>   entity who should be writing to those (patch 3/4)
> - when constructing the link between router and switch 'struct ovn_port'
>   peers ovn-northd was incorrectly querying the ports map sometimes
>   selecting "not bound" ovn ports in favor of "bound" ones (with a
>   ovn_datapath pointer set).  This could lead to some of the logical
>   flows being updated *after* the transaction that recreated datapath
>   bindings happened, potentially affecting traffic. (patch 4/4)
>
> Patches 1-2 should go to main and 25.09.  Patches 3-4 should be
> backported to all stable branches.
>
> Changes in v2:
> - v1 only had the schema update, v2 now includes fixes to all the issues
>   uncovered while debugging Ilya's bug report:
>   https://mail.openvswitch.org/pipermail/ovs-dev/2025-August/425790.html
>
> Dumitru Ceara (4):
>   ovn-sb: Make Datapath_Binding.type optional to avoid upgrade issues.
>   northd, controller: Reconcile SB datapaths to new type in a single
>     run.
>   northd: Omit alert for write-only SB.Static_Mac_Binding table.
>   northd: Always prefer bound ovn_port versions when available.
>
>  lib/ovn-util.c            | 27 ++++++++--------------
>  lib/ovn-util.h            |  5 ++--
>  northd/en-datapath-sync.c |  3 ++-
>  northd/northd.c           | 48 +++++++++++++++++++++------------------
>  northd/northd.h           |  4 ++++
>  northd/ovn-northd.c       |  4 ++++
>  ovn-sb.ovsschema          |  5 ++--
>  7 files changed, 52 insertions(+), 44 deletions(-)
>
> --
> 2.50.1
>
>
Thank you Dumitu,

I went ahead and merged only 3/4 and 4/4 and backported them all the way
down to 24.03.

Regards,
Ales
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to