On 10/10/25 1:23 PM, Kevin Traynor wrote:
> On 09/10/2025 10:21, Ilya Maximets wrote:
>> For some reason GCC 4.8 doesn't like this style of initialization,
>> complaining that nla_type is missing in the initializer:
>>
>> tests/test-netlink-policy.c: In function 'test_nl_policy_parse_ll_addr':
>> tests/test-netlink-policy.c:60:9:
>> error: missing initializer for field 'nla_type' of 'struct nlattr'
>> [-Werror=missing-field-initializers]
>> .nlattr.nla_type = TEST_POLICY_ATTR,
>> ^
>
> that is surprising
It is. Might be a bug or just some weird behavior in that old GCC.
>
>> Let's use a normal designated initializer for the nested structure
>> to avoid this issue.
>>
>> Fixes: 2f2ae5b6bdef ("tests: Fix endianness in netlink policy test
>> fixtures.")
>> Signed-off-by: Ilya Maximets <[email protected]>
>> ---
>> tests/test-netlink-policy.c | 15 +++++----------
>> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> Acked-by: Kevin Traynor <[email protected]>
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
