On 10/10/25 1:47 PM, Eelco Chaudron wrote:
>
>
> On 9 Oct 2025, at 11:21, Ilya Maximets wrote:
>
>> When building using an older compiler that doesn't support avx512,
>> we are adding '-mno-avx512f' into the command line, which results
>> with a build failure:
>>
>> gcc: error: unrecognized command line option '-mno-avx512f'
>>
>> This is a case, for example, while trying to build OVS with GCC 4.8.
>>
>> Fix that by avoiding binutils check when compiler doesn't understand
>> -mavx512f.
>>
>> Later in the call chain there is also an explicit check for -mavx512f
>> support, but it will just use the cached result, so it's not a problem.
>>
>> Fixes: 930f135f5ddc ("configure: explicitly disable avx512 if bintuils check
>> fails")
>> Signed-off-by: Ilya Maximets <[email protected]>
>
> Thanks for digging into the root cause of these compiler failures! At first,
> I thought I’d have to comment on the indentation after your change, but then
> I noticed the rest of the file also has that one-character indent. So I guess
> it’s “consistent style” now ;)
Ideally, we need 2-space alignment here, which is a custom in m4 and
autotests, but when I did it this way initially, it's so hard to see
what changed by looking at the diff. So, I decided to just keep the
diff simple instead. Hopefully, we can remove this entire section
at some point...
>
> Acked-by: Eelco Chaudron <[email protected]>
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
