Hi Dumitru Thanks for the series, for the v2, and for fixing many missing cleanups.
I think that there are a few remaining missing cleanup (e.g. ovn-ipam.at), or a few not properly done (e.g. OVN_CLEANUP w/o argument will not stop any running ovn-controller). However, as we now have a JIRA (2864) for trying to register all cleanup, and as this task fixes many tests, definitely improves our tests, this patch series fulfills its goal (see title: *some* of the missing cleanups) I'd like to give a LGTM and For the serie: Acked-by: Xavier Simonart <[email protected]> Thanks Xavier On Wed, Dec 10, 2025 at 11:06 AM Dumitru Ceara <[email protected]> wrote: > Commit d1f4150bbe88 ("tests: Ensure all central components stop at the > end of the test.") tried to address the missing cleanup for northd in > OVN tests. It only partially managed to do that. It also turns out we > were missing lots of other cleanups in our tests which could potentially > hide issues, e.g., when the tests are run with sanitizers enabled. > > NOTE: ideally this all should be done in a more reliable way, e.g., by > having all the _START() helpers register proper cleanup code instead > relying on the test writer to call the correct cleanup macros. But > until we get that (Xavier is looking into it) we might as well fix up > our current tests. > I just opened https://issues.redhat.com/browse/FDP-2864 to track this effort. > > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-dev/2025-December/428375.html > Reported-by: Xavier Simonart <[email protected]> > > V2: > - turned this into a series that handles more of the cleanup issues in > our tests (thanks to Xavier's report on the v1 patch!) > > Dumitru Ceara (8): > tests: Add missing OVN_CLEANUP_NORTHD calls. > tests/ovn-controller-vtep: Add missing OVN_CONTROLLER_VTEP_STOP calls. > tests/ovn-controller-vtep: Remove unused test net. > tests: Add OVN_CLEANUP_DBS and use it in tests that already stopped > northd. > tests/ovn: Add missing OVN_CLEANUP calls. > tests/ovn: Add missing partial cleanups. > tests/ovn-controller: Add missing cleanup. > tests/ovn-ic: Add missing OVN_CLEANUP_IC call. > > tests/ovn-controller-vtep.at | 12 +++++++- > tests/ovn-controller.at | 50 +++++++++------------------------- > tests/ovn-ic.at | 2 ++ > tests/ovn-macros.at | 13 +++++++-- > tests/ovn-northd.at | 2 ++ > tests/ovn.at | 53 +++++++++++++++++++++++++----------- > tests/perf-northd.at | 4 +++ > tests/system-ovn.at | 9 +----- > 8 files changed, 80 insertions(+), 65 deletions(-) > > -- > 2.51.1 > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
