On 12/10/25 12:38 PM, Xavier Simonart wrote: > Hi Dumitru > > Thanks for the series, for the v2, and for fixing many missing cleanups. > > I think that there are a few remaining missing cleanup (e.g. ovn-ipam.at), > or a few not properly done (e.g. OVN_CLEANUP w/o > argument will not stop any running ovn-controller). > However, as we now have a JIRA (2864) for trying to register all cleanup, > and as this task fixes many tests, definitely improves our tests, this > patch series fulfills its goal (see title: *some* of the missing cleanups) > I'd like to give a LGTM and > For the serie: Acked-by: Xavier Simonart <[email protected]> >
Hi Xavier, Thanks a lot for the review! Applied to main and all stable branches. It did uncover a bug in ovn-northd. I opened an issue on our side to get that addressed: https://issues.redhat.com/browse/FDP-2869 In CI I only hit this once out of quite a few runs, so I guess it's fine to leave it as is for now. > Thanks > Xavier > > On Wed, Dec 10, 2025 at 11:06 AM Dumitru Ceara <[email protected]> wrote: > >> Commit d1f4150bbe88 ("tests: Ensure all central components stop at the >> end of the test.") tried to address the missing cleanup for northd in >> OVN tests. It only partially managed to do that. It also turns out we >> were missing lots of other cleanups in our tests which could potentially >> hide issues, e.g., when the tests are run with sanitizers enabled. >> >> NOTE: ideally this all should be done in a more reliable way, e.g., by >> having all the _START() helpers register proper cleanup code instead >> relying on the test writer to call the correct cleanup macros. But >> until we get that (Xavier is looking into it) we might as well fix up >> our current tests. >> > I just opened https://issues.redhat.com/browse/FDP-2864 to track this > effort. > Yes, let's try to fix this the right way in the future. Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
