> On 24 Aug 2018, at 20:45, Ben Pfaff <[email protected]> wrote: > > On Wed, Aug 22, 2018 at 04:12:03PM +0300, [email protected] wrote: >> Regarding the IDL ones: >> Most of them failed because of: >> Traceback (most recent call last): >> File "../.././test-ovsdb.py", line 892, in <module> >> main(sys.argv) >> File "../.././test-ovsdb.py", line 887, in main >> func(*args) >> File "../.././test-ovsdb.py", line 701, in do_idl >> while idl.change_seqno == seqno and not idl.run(): >> File "c:\ovs\python\ovs\db\idl.py", line 214, in run >> self._session.run() >> File "c:\ovs\python\ovs\jsonrpc.py", line 527, in run >> self.__connect() >> File "c:\ovs\python\ovs\jsonrpc.py", line 462, in __connect >> error, self.stream = ovs.stream.Stream.open(name) >> File "c:\ovs\python\ovs\stream.py", line 190, in open >> error, sock = cls._open(suffix, dscp) >> File "c:\ovs\python\ovs\stream.py", line 744, in _open >> sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1) >> File "c:\Python27\lib\socket.py", line 228, in meth >> return getattr(self._sock,name)(*args) >> socket.error: [Errno 10022] An invalid argument was supplied >> >> I added the incremental: >> diff --git a/python/ovs/stream.py b/python/ovs/stream.py >> index ca0d84425..762e1e212 100644 >> --- a/python/ovs/stream.py >> +++ b/python/ovs/stream.py >> @@ -741,7 +741,10 @@ class TCPStream(Stream): >> error, sock = ovs.socket_util.inet_open_active(socket.SOCK_STREAM, >> suffix, 0, dscp) >> if not error: >> - sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1) >> + try: >> + sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1) >> + except: >> + return errno.EINVAL, None >> return error, sock >> >> However I'm unsure of the above. > > Hmm. At least on unixlike systems, TCP_NODELAY is somewhat important > because otherwise you tend to get high latencies due to the Nagle > algorithm. Does Windows have Nagle? Is there a different way to turn > it off there?
Sorry for the late reply. Windows has Nagle and supports TCP_NODELAY, and it works, but when running the tests with multiple remotes I get that error. I’ll try to figure what happened. Thanks, Alin. _______________________________________________ discuss mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
