On 11/03/2011 14:34, Vincent Danjean wrote:
> I will send one message per patch I applied with some comment and a last
> one with global comments and questions.
At first, there is no seventh patch. I made a mistake when I counted all
patch initially ;-)
Some remarks about owfs from a packager point of view:
- owfs mostly respect --prefix and DESTDIR (with the exception of
TCL and Perl, see comments in their patches) and most linkage
is already correct. This is a great point :-) Lots of complex
software is not in this state.
- about manpages, I think that some sections should be reviewed.
For examples, I think that all technical (DS*, ...) manpages
should belong to the 7th section. Library documentation (functions
*and* global manpage about libraries such as ownet.1) should belong
to the 3rd section
And helper manpage parts (*.Xso) should not be installed when doing
"make install"
- about soname: you change the soname of each libraries at each release.
Of course, you are sure not to break binary compatibility (as the soname
change said that there is none). However, this means that, from a
distribution point of view, a library transition will need to be handle
distribution-wide at each new release of owfs. For now, this is not
really a problem as nothing external to owfs depend on it. But, if
owcapi, ownet or ow libraries are used by external programs, this could
be a burden.
Would you be interested in defining a binary interface for each library
(ie a list of public symbols) ? It can then be enforced with a linker
script. You will be allowed to add new symbol whenever you want. But
deleting or renaming a public symbol would have to be carefully reviewed
as this requires a soname bump.
The Debian package has a list of all symbols if you want to work on this
point.
- I would welcome a default config file. For owserver, owhttpd and owftpd,
the init scripts provided in the Debian package will load config in
/etc/owfs.conf by default. But owfs has no init script.
My goals is that, by default, Debian packages use owserver to access the
1-wire hardware and all other softwares listened to owserver on localhost
by default (of course, an admin can easily change all these defaults)
Regards,
Vincent
------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Owfs-developers mailing list
Owfs-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/owfs-developers
