On Fri, Mar 11, 2011 at 9:53 AM, Vincent Danjean <vdanjean.p...@free.fr> wrote:
> On 11/03/2011 14:34, Vincent Danjean wrote:
>> I will send one message per patch I applied with some comment and a last
>> one with global comments and questions.
>
> At first, there is no seventh patch. I made a mistake when I counted all
> patch initially ;-)
>
> Some remarks about owfs from a packager point of view:
> - owfs mostly respect --prefix and DESTDIR (with the exception of
>  TCL and Perl, see comments in their patches) and most linkage
>  is already correct. This is a great point :-) Lots of complex
>  software is not in this state.

Thank you. This is a tribute to people like Christian Magnusson, Geo Carncross
and the many others who designed the build scripts.

> - about manpages, I think that some sections should be reviewed.
>  For examples, I think that all technical (DS*, ...) manpages
>  should belong to the 7th section. Library documentation (functions

I've had other commenters suggest secion 5 for the DSxxxx files.

>  *and* global manpage about libraries such as ownet.1) should belong
>  to the 3rd section
>  And helper manpage parts (*.Xso) should not be installed when doing
>  "make install"

I think the .so inclusion files are inserted in the install process currently.

> - about soname: you change the soname of each libraries at each release.
>  Of course, you are sure not to break binary compatibility (as the soname
>  change said that there is none). However, this means that, from a
>  distribution point of view, a library transition will need to be handle
>  distribution-wide at each new release of owfs. For now, this is not
>  really a problem as nothing external to owfs depend on it. But, if
>  owcapi, ownet or ow libraries are used by external programs, this could
>  be a burden.

I'm confused.
owlib (libow) is specific to each release and is probably not cross compatible.
owfs, owhttpd, owserver, owftpd, should al match version with owlib.

ownet doesn't use a library

owcapi needs to match owlib, but linking to it should be stable.

>  Would you be interested in defining a binary interface for each library
>  (ie a list of public symbols) ? It can then be enforced with a linker
>  script. You will be allowed to add new symbol whenever you want. But
>  deleting or renaming a public symbol would have to be carefully reviewed
>  as this requires a soname bump.

Yes for owcapi.


>  The Debian package has a list of all symbols if you want to work on this
>  point.
> - I would welcome a default config file. For owserver, owhttpd and owftpd,
>  the init scripts provided in the Debian package will load config in
>  /etc/owfs.conf by default. But owfs has no init script.
>  My goals is that, by default, Debian packages use owserver to access the
>  1-wire hardware and all other softwares listened to owserver on localhost
>  by default (of course, an admin can easily change all these defaults)

Good idea.

>
>  Regards,
>    Vincent
>

------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Owfs-developers mailing list
Owfs-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/owfs-developers

Reply via email to