Sorry if I repeat myself, but this problem is still unsolved as of branch master 0ea833c.

$ git grep -n '#include <[a-z]*usb\.h>'
module/owlib/src/include/ow.h:305:#include <libusb.h>
module/owlib/src/include/ow_usb_cycle.h:58:#include <usb.h>

If I got it right, current OWFS uses libusb-1.0, which requires to include <libusb.h>. The include at line 58 of ow_usb_cycle is a leftover of the libusb-0.1 API.

It seems to me that line 58 in ow_usb_cycle.h is completely redundant, since <libusb.h> has already been loaded in ow.h:305. I would suggest simply delete line 58 and 57 in ow_usb_cycle.h

I think it is important to fix this problem because it mixes two different APIs and prevents compilation on system which do not have the legacy libusb installed.

Stefano

Attachment: 0001-quick-fix-for-usb-header.patch
Description: Binary data

------------------------------------------------------------------------------
_______________________________________________
Owfs-developers mailing list
Owfs-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/owfs-developers

Reply via email to