On 03/10/16 02:29, Jan Kandziora wrote: > Am 09.03.2016 um 23:39 schrieb Arnout Vandecappelle (Essensium/Mind): >> compat_netdb.h is added for only one reason: to provide the definitions >> for getaddrinfo, in case it is not provided by the system. >> compat_netdb.h is just a copy from an old glibc version, but that makes >> it incompatible with other standard C libraries. For example, uClibc >> without RPC support doesn't have the rpc/netdb.h header. This leads to >> build errors. >> > Ah, I wasn't sure what this was all about. Made me a headache with the > Cygwin build. > > >> To work around this, only include compat_netdb.h when needed, i.e. >> when getaddrinfo isn't provided natively. >> > So, your are sure this is only about getaddrinfo()? We can't ask > Christian Magnusson, I think.
The header declares getaddrinfo, freeaddrinfo and their associated struct and constants. In addition, it declared inet_ntop and inet_pton (protected by their respective HAVE_*). inet_pton isn't used in owfs, but inet_ntop is. And indeed, that function will be defined in getaddrinfo.c when inet_ntop isn't available on the system... OK, so I should rework the patch so that the rpc/netdb.h part of the include is moved inside the #ifndef HAVE_GETADDRINFO chunk. Unless of course we decide that a system-supplied getaddrinfo (and inet_ntop) is required, and remove the compat stuff completely. If that is preferred, I can make a patch for it. Thanks, Regards, Arnout -- Arnout Vandecappelle arnout dot vandecappelle at essensium dot com Senior Embedded Software Architect . . . . . . +32-478-010353 (mobile) Essensium, Mind division . . . . . . . . . . . . . . http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium . . . . . BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785111&iu=/4140 _______________________________________________ Owfs-developers mailing list Owfs-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/owfs-developers
