Am 30.11.2016 um 23:32 schrieb John Bass:
> 
> Yep the gpio 1w driver. I'm a little surprised the clock speed makes
>  a difference, would have expected that to have been taken into 
> consideration by the driver developers.
> 
In theory all is timed but when the clock speed is out of bounds, the
calculation formula could be wrong.


> How would you like me to generate the patch?
> 
Install git and gitk.

Setup git:

$ git config --global user.name "John Bass"
$ git config --global user.email "j...@johnbass.co.uk"

Clone the owfs git repository from sf.net (or github, that's a mirror):
Use gitk to get an overview about commits.

$ git clone https://github.com/owfs/owfs.git
$ cd owfs
$ gitk&

(later: pull the newest version with "git pull" instead)

Bootstrap the repository to prepare it for your test compiles:

$ ./bootstrap
$ ./configure

*** Apply your patches ***

Do a test.

$ make
$ sudo make install

Commit your patches:

$ git commit -m "added support for DS2438 with 0xA6 family code"
modules/owlib/...

Export your patch in a format suitable for inclusion into the archive:

$ git format-patch master --stdout <old_id>..<new_id>

<old_id> and <new_id> are the SHA1 ids as shown by the git tools, e.g. gitk&

Make the email subject read "[PATCH 1/1]: added support for DS2438 with
0xA6 family code"

Give further explanations on the "why" on top of the email and end these
with a line

Signed-off: "John Bass <j...@johnbass.co.uk>"

Then paste that patch into an email (not as an attachment, just a plain
pasting). Disable automatic line-breaking.


That's the procedure as used by the Linux kernel maintainers. We have
far less patches than them so we can accept stray patches too, but
adapting their procedure sure helps you to get patches accepted
everywhere. It's just good practice.

Kind regards

        Jan



------------------------------------------------------------------------------
_______________________________________________
Owfs-developers mailing list
Owfs-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/owfs-developers

Reply via email to