Note that https://github.com/apache/hadoop-ozone/pull/921 only changes the line length at this stage, not the import order.
I am +1 on the increased line length. I find the current length of 80 results in a lot of line wraps for only a few characters, or sometimes a line that needs to wrap a few times. This makes the code less readable. For the import order, I have no problem with it either, except it will require most files to be modified to meet the new check. Probably best if we keep these as two separate changes? On Tue, May 19, 2020 at 10:20 AM Elek, Marton <e...@apache.org> wrote: > > > Please note that some checkstyle changes are proposed by @maobaolong > > Most important changes: > > * Increase the maximum length of the lines (80-120) > * Force import order (reduce conflicts) > > > > https://issues.apache.org/jira/browse/HDDS-3582 > > https://github.com/apache/hadoop-ozone/pull/921 > > > Please add your comments, if you have. > > Marton > > --------------------------------------------------------------------- > To unsubscribe, e-mail: ozone-dev-unsubscr...@hadoop.apache.org > For additional commands, e-mail: ozone-dev-h...@hadoop.apache.org > >
