adoroszlai commented on a change in pull request #196: HDDS-2516. Code cleanup
in EventQueue
URL: https://github.com/apache/hadoop-ozone/pull/196#discussion_r347081611
##########
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/events/Event.java
##########
@@ -20,16 +20,16 @@
/**
* Identifier of an async event.
*
- * @param <PAYLOAD> THe message payload type of this event.
+ * @param <P> THe message payload type of this event.
*/
-public interface Event<PAYLOAD> {
+public interface Event<P> {
Review comment:
I was kind of afraid of making this part of the change. ;) I think the
rationale is that ALL_CAPS are for constants. I personally prefer the
compliant version. However, I would be happy to hear from more people about
this. I will change it back to the original (and mark the Sonar issues as
"won't fix") if others also prefer the long version. Is that OK?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
