adoroszlai commented on a change in pull request #196: HDDS-2516. Code cleanup
in EventQueue
URL: https://github.com/apache/hadoop-ozone/pull/196#discussion_r348213049
##########
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/events/Event.java
##########
@@ -20,16 +20,16 @@
/**
* Identifier of an async event.
*
- * @param <PAYLOAD> THe message payload type of this event.
+ * @param <P> THe message payload type of this event.
*/
-public interface Event<PAYLOAD> {
+public interface Event<P> {
Review comment:
Thanks @anuengineer for looking up the rule and researching it on the net,
too. Since there was no agreement on changing the names, I updated to the
previous state as promised.
> Here is one guy who actually agrees with you ..
> https://www.vojtechruzicka.com/break-java-generics-naming-convention/
I think it's worth noting that none of his three options is "use ALL_CAPS"
(only mentioned in the comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
