[
https://issues.apache.org/jira/browse/HDDS-2903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031964#comment-17031964
]
Bharat Viswanadham commented on HDDS-2903:
------------------------------------------
Hi [~aengineer]
Thank You for your review and concern on usability. I completely agree with
you, and we missed the documentation of this.
{quote}So the user now needs to know that they can only create
raft.grpc.(server or tls) namespace keys or raft.server.cannot use any number
here?
{quote}
Agreed that right now out regex is brittle. I figured out that we can use
getPropsWithPrefix() and set the RatisConfiguration which will avoid the
problem caused by regex pattern. And also we shall use same prefix to match
ratisClient and ratisServer for DN to avoid the confusion which is there
currently.
{quote}How is any user going to know any of this? how is any programmer going
to know any of this?
{quote}
I will open a documentation Jira under beyond Basics section, we can add a
section like Advanced Configuration Tuning. I am open to any other suggestions
also for better user experience.
> Use regex to match with ratis properties when creating ratis server
> --------------------------------------------------------------------
>
> Key: HDDS-2903
> URL: https://issues.apache.org/jira/browse/HDDS-2903
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Datanode
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available, teragentest
> Fix For: 0.5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This Jira is to use regex which are matching with ratis server and ratis grpc
> properties and set them when creating ratis server.
> Advantages:
> # We can use ratis properties directly, don't need to create corresponding
> ozone config.
> # When new properties are added in ratis server, we can set them and use
> them without any ozone code changes.
> In this Jira not removed the existing properties, if this looks fine, we can
> remove in a clean up Jira to remove ozone config for ratis server or leave as
> it is for existing ones.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
