[
https://issues.apache.org/jira/browse/HDDS-2903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031993#comment-17031993
]
Anu Engineer commented on HDDS-2903:
------------------------------------
My concern is not only usability. Please look at the OzoneConfigration class,
you will see that it reads a set of XML config files. Why can't ratis be one
more of them?
There is also significant work done by [~elek] where you can annotate a config
class to generate the configs.
This is yet another way to do the same thing. How many ways will we have for
setting ozone configs? all of this adds to the surface area of Ozone.
What I am really trying to understand is why we cannot use any of the existing
ways of setting configs, and why we need this new way. The fact that it is
brittle and error-prone is just an observation from the code review.
> Use regex to match with ratis properties when creating ratis server
> --------------------------------------------------------------------
>
> Key: HDDS-2903
> URL: https://issues.apache.org/jira/browse/HDDS-2903
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Datanode
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available, teragentest
> Fix For: 0.5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This Jira is to use regex which are matching with ratis server and ratis grpc
> properties and set them when creating ratis server.
> Advantages:
> # We can use ratis properties directly, don't need to create corresponding
> ozone config.
> # When new properties are added in ratis server, we can set them and use
> them without any ozone code changes.
> In this Jira not removed the existing properties, if this looks fine, we can
> remove in a clean up Jira to remove ozone config for ratis server or leave as
> it is for existing ones.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
